More plugin hooks please

[mpdaddy]

Can we get more hooks added to the core code to make creating plugins much easier? For example, the add_form.html template file has 2 hooks inside it. The problem is that neither hook is placed between the <form></form> tags. Therefore, you cannot pass variables to the form itself. I think there should be 2 hooks outside the form and at least 1 inside.

Another example is the add.php file. Why are there no hooks inside this file? Is this going to be expanded in the near future? Can we get some added before the next release (v1.2)?

Regards
Wayne

[Bruceper]

1.2 may be a while away. We should be coming out with 1.11 in the next week or so.

But in regards to hooks, I'll definately see what can be done.

[mpdaddy]

Thank you. That would be great. I am getting plugin requests and I have seen a few requests on the forum. Without having the hooks in the correct places, plugins will need to be very basic. The PR plugin requested yesterday could not be accomplished with the current code. I can think of a few others too.

Regards
Wayne

[nakos]

hello wayne

i have added the new hook on add_form.html,

hook_html_add_form_inside_form_begin and hook_html_add_form_inside_form_end

you can update on http://nicecoder.com/svn/index.php?act=changeset&id=888

note :

Another example is the add.php file. Why are there no hooks inside this file? Is this going to be expanded in the near future? Can we get some added before the next release (v1.2)?

actually, we have no idea to add any new hook. we need any suggestion and any feedback for bouth of php_hook and html_hook from you.

you can give us any cases to add new hook or plugin.

thanks

[Bruceper]

As a note, I suggested to the programmers that hooks simply be added everywhere that they can be. If they aren't used then it doesn't matter, they would still be there for future versions and other ideas.

[mpdaddy]

note :

actually, we have no idea to add any new hook. we need any suggestion and any feedback for bouth of php_hook and html_hook from you.

you can give us any cases to add new hook or plugin.

thanks

A examples in the add.php file, there could be a php hook just before line #35

$title = $_POST['title'];

could be

$plug->PluginPlace("hook_php_add_show_form_begin");

$title = $_POST['title'];

and after line #193

$basic_listing_price = $basic_price;

could be

$basic_listing_price = $basic_price;

$plug->PluginPlace("hook_php_add_show_form_end");

You could then add a begin and ending hook inside the ProcessFormAddUrl() function.

It is my opinion that there should be a plugin hook in almost all of the main files that control IndexU. Along with the add.php and add_form.html files, there should be hooks in the modify.php, modify_form.html, login.php, login_form.php, rows.html, premium_rows.html, sponsored_rows.html, etc, etc.

Some of the html files already have hooks in them like the rows.html file for example.

<%$hook_html_premium_rows_begin%>      

<div class="premium_link_rows">
	<div class="link_rows">
		<span><a href="<%$url%>" name="link_<%$link_id%>"><%$title%></a></span>
    <%if $enable_bidding%>
      [<a href="<%$site_url%>/upgrade.php?pflag=retrieve&id=<%$link_id%>"><%t%>bid<%/t%></a> $<%$bid%>]
    <%/if%>
    <br />
    <%$description%>
    <br />
    <a href="<%$url%>" name="link_<%$link_id%>"><%$url%></a> 
    - <a href="<%$site_url%>/<%$detail_page_url%>">Detail</a>
    <br /><span class="googlepr">Google PR <img src="<%$site_url%>/googlepr.php?link_id=<%$link_id%>"></span>
	</div>
</div>

<%$hook_html_premium_rows_end%>

There are 2 hooks, but neither of them are inside the <div></div> tags. Therefore it is impossible to add content to these area using a plugin.

All of the files should have hooks inside the content areas.

Regards
Wayne

[Bruceper]

It is my opinion that there should be a plugin hook in almost all of the main files that control IndexU

I 100% agree with you and that's what I told the programmers. Add them everywhere and don't worry about what they're going to be used for.

[mpdaddy]

Agreed.. You cannot simply guess where someone might need a hook for a plugin. You will not know where you need it before you start making a plugin. I am not suggesting we fill the script with a hook every 10 lines, but make them plentiful and then add more as needed in the future. A hook should be in nearly every major function in the script.

Regards
Wayne

[mpdaddy]

Just another note, plugin hooks should be created in both the user area and the admin. While attempting to add functionality to my current plugin, I wanted to add a javascript include into the header.html file in the admin. There are no hooks in that file though. There are several in the user area header.html file, but none in admin.

Regards
Wayne

[Bruceper]

Hooks in the admin panel? I don't see why not. Permission granted!

They could be used to add new sections, new menus and all sorts of stuff.

Personal note - if i"m not around after this week it's because Dody and crew beat me up after all these requests for hooks and the changes to the admin panel. They're going to have to go through every function! But the script will be better for it so it's all good.

[mpdaddy]

Personal note - if i"m not around after this week it's because Dody and crew beat me up after all these requests for hooks and the changes to the admin panel. They're going to have to go through every function! But the script will be better for it so it's all good.

Here is a script with plenty of hooks for plugins. It is a totally unrelated type of script, but it lists all the hooks and what files they are in. Some files have 2 hooks and some have 20 hooks. It is going to be quite a task to go through all those functions, but like you said, the script will be better for it.

http://wiki.mybboard.net/index.php/MyBB_Plugin_Hooks

Regards
Wayne

[FSGDAG]

Hey Bruce....

I was wondering if having hooks placed "everywhere" was being worked on and if it was going to be in the next release of IndexU? Is the next release of IndexU coming this week?

[Bruceper]

So far I haven't heard anything about the new hooks being added, which doesn't make me too happy.

And yes 1.2 is supposed to release this week and I might make them delay it until the hooks are added. Or maybe make them work a heck of a lot faster so it can be released this week.

Stay tuned!

[FSGDAG]

Or maybe make them work a heck of a lot faster so it can be released this week.

Stay tuned!

Yeah... This option sounds better to me!

[Bruceper]

I have been informed that new hooks have already been added. Please be patient as I don't know if there are enough of them yet. We're working hard to impliment as many feature requests as we can.

There are already hooks in the admin panel menu, and I'm talking to Dody about others in the admin panel as well (in summary.php mostly)