User Validation Fix

[mbarnett]

I noticed that if you have Enable User Validation turned off, the email (mail/register.mail) still sends the validation link.

If the user clicks on the link, they get a failed validation because line 164 in lib/users.class.php

$query = "select vcode from $this->table_name where username='$username' and status = 0";

Since status is already set to 1, the validation will fail.

Either the " and status = 0" should be removed

or

the email should be changed to send the link based on Enable User Validation value.

mail/register.mail

Thanks for joining <%$site_name%>.

username : <%$username%>
password : <%$password%>


<%if $enable_user_validation%>
Please confirm your registration here:
<%$site_url%>/register.php?u=<%$username%>&v=<%$vcode%>&pflag=cf
<%/if%>

Sincerely,

<%$site_name%> Team

[dody]

Thanks. Here is an update code: http://nicecoder.com/svn/index.php?act=changeset&id=338