Go Back   NiceCoder Community Forums > Nicecoder > Bug Reports
Register Projects FAQ Members List Mark Forums Read

 
 
LinkBack Thread Tools Display Modes
  #1 (permalink)  
Old 04-05-2008, 07:27 PM
Active Member
 
Join Date: Nov 2007
Posts: 175
mpdaddy is on a distinguished road
Default Problem in both version 5.4 and 6.0

I am posting this in hopes that Dody will fix it in the SVN prior to releasing version 6.0. This would take 1 minute to update and is a problem in both version 5.4 and still in 6.0. Here is the bug or problem.

Go to your link submit form (add.php) and submit a link without using http:// (Add mytestdomain.com.com for example).

I know it is already entered into the form by default, but IndexU users are getting submissions without the http://. I know this because I have fixed it for at least 2 users who were getting submissions without the http://.

No go to your admin and view the link by clicking on "Validate Links". For this example, lets say the domain submitted was mytestdomain.com. If you try to visit the link it will take you to http://www.yourdomain.com/test/admin/mytestdomain.com. You have to go and modify the link and add the http:// onto it. If you accept the domain and add it to your site without correcting the error, it will take you to http://www.yourdomain.com/categoryname/mytestdomain.com while browsing the category, and in the detail page it will take you to http://www.yourdomain.com/detail/lin...testdomain.com.

Now how do we fix it? The way I have been doing it is to check the form to make sure it has all the properties of a valid domain name using $urlinfo['host']. With my fix, if a domain is submitted without the http://, it will automatically add it before adding the link to the database. Here is my code to fix this issue.

Open the add.php file (upload/add.php) and find the area of code like this:

Code:
Content visible to License Owner only.
Add the code just below the $title = $_POST['title'];

Code:
Content visible to License Owner only.
That section should now look like this:

Code:
Content visible to License Owner only.
Be aware that there are 2 identical $title = $_POST['title']; sections of code in this file if you add this modification. This modification should be within the ProcessFormAddUrl() function on or about line 218.

This would only take the programmers a minute or two to modify and would eliminate the need for users to modify their own script to do something it should do right out of the box.

If you have opinions or have a better solution to this problem, feel free to post your comments. If you have ever had a submission without http:// and had to do this, post to this thread. Maybe we can get this added before the release next week.

Regards
Wayne
__________________
For questions related to any mods I developed, please contact me by pm or email at webmaster [at] scriptdragon [dot] com
  #2 (permalink)  
Old 04-05-2008, 11:28 PM
FSGDAG's Avatar
Moderator
 
Join Date: May 2007
Location: NJ, United States
Posts: 980
FSGDAG is on a distinguished road
Default

I cant tell you the amount of times I get submssions like this ( without the "http://" ). I think its being done by auto-submission programs, like RoboForm or IBP, etc. The submission programs will overwrite whats already populated in the text area.
__________________
FSGDAG | IndexU Hosting | Owner
Website | NiceCoder Script Hosting and More! | Blog
General Directory | Deep Links Directory | Bidding Directory
  #3 (permalink)  
Old 04-28-2008, 10:44 PM
Active Member
 
Join Date: Nov 2007
Posts: 175
mpdaddy is on a distinguished road
Default

This bug is still in the new version.
__________________
For questions related to any mods I developed, please contact me by pm or email at webmaster [at] scriptdragon [dot] com
  #4 (permalink)  
Old 04-29-2008, 10:22 PM
dody's Avatar
Nicecoder Team
 
Join Date: Aug 2001
Location: Indonesia
Posts: 3,292
dody is a name known to alldody is a name known to alldody is a name known to alldody is a name known to alldody is a name known to alldody is a name known to all
Default

Fixed.
http://nicecoder.com/svn/index.php?act=changeset&id=779
 

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On

Similar Threads
Thread Thread Starter Forum Replies Last Post
character problem after upgrading php version to 4.4.2 gtithesexy v5.x 0 10-11-2006 07:42 AM
Version 5.1.0 problem jhanna v5.x 3 04-12-2006 12:37 AM
Dropdown menu and version 5.03 problem jhanna v5.x 3 04-02-2006 07:16 PM
Version 4 morgankd v5.x 2 08-31-2004 01:59 AM
difference between the full version and the lite version Frisk151 Pre-Sales Questions 3 08-04-2003 10:21 AM

HACKER SAFE certified sites prevent over 99.9% of hacker crime.

All times are GMT -5. The time now is 03:14 PM.


Powered by vBulletin®
Copyright ©2000 - 2009, Jelsoft Enterprises Ltd.
Search Engine Friendly URLs by vBSEO
SSL Certificate